support optimistic locking for ResourceForm
#4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
wings-version-form
branch
from
8caabd0
to
1d66c92
Compare
introduces a field and prepopulator for the (maybe confusingly named?) `version` virtual attribute. `Hyrax::WorkForm` implements this by calling `model.etag`, but we don't have that luxury here (since non-fedora backed valkyrie may not have an etag at all). the logic added here is specific Wings adapter, pulling out the etag for compatibility. it's probably okay to keep this wings-specific indefinitely. other adapters should support optimistic locking internally (indeed, so does Wings) so we can phase out application-layer lock validation in favor of leaning on Valkyrie/backend datastore features.
no-reply
force-pushed
the
wings-version-form
branch
from
1d66c92
to
ee2af33
Compare
jeremyf
reviewed
May 29, 2020
| # pending handling for #version/optimistic locking, and maybe other | ||
| # issues. a good way to make progress on ChangeSet forms is to enable | ||
| # this test, analyze the stacktrace, and try to patch. | ||
| it 'renders a form' do |
There was a problem hiding this comment.
Always great to see a xit become a run spec!
jeremyf
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces a field and prepopulator for the (maybe confusingly named?)
versionvirtual attribute.
Hyrax::WorkFormimplements this by callingmodel.etag,but we don't have that luxury here (since non-fedora backed valkyrie may not
have an etag at all). the logic added here is specific Wings adapter, pulling
out the etag for compatibility.
it's probably okay to keep this wings-specific indefinitely. other adapters
should support optimistic locking internally (indeed, so does Wings) so we can
phase out application-layer lock validation in favor of leaning on
Valkyrie/backend datastore features.
@samvera/hyrax-code-reviewers