create a better label for proxy deposits. #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! can i ask @samvera/hyrax-repo-managers to chime in about the english text, before we end up with auto-translations? https://github.com/samvera/hyrax/pull/4378/files#diff-bbdd52b7c22bb8037e7c2365065a825eR426
|
|
not seeing any replies, i'm unwilling to hold this any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
When depositing a work as a proxy depositor, the label presented to the user simply says "On behalf of". This is not user friendly, so a better label was suggested in the issue. With this PR, the label becomes "Proxy Depositors - Select the user on whose behalf you are depositing"
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers