Refining behavior of UsersController#base_query #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
improving-documentation-and-behavior
branch
from
8dd6ef3
to
dec6e0c
Compare
no-reply
reviewed
Jun 30, 2020
jeremyf
force-pushed
the
improving-documentation-and-behavior
branch
from
dec6e0c
to
799da70
Compare
This commit clarifies the behavior, the public @api nature of the method, and adds another test case around hash based parameters. As I was exploring Postgresql, I believe the `[nil]` as a query parameter may have caused an issue. This change should preserve the previous "public" implementation.
jeremyf
force-pushed
the
improving-documentation-and-behavior
branch
from
799da70
to
f507d0a
Compare
no-reply
approved these changes
Jun 30, 2020
no-reply
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies the behavior, the public @api nature of the
method, and adds another test case around hash based parameters.
As I was exploring Postgresql, I believe the
[nil]as a queryparameter may have caused an issue.
This change should preserve the previous "public" implementation.
@samvera/hyrax-code-reviewers