Adjusting UsersController#search for agnosticism #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, I believe the syntax was less generalize. In particular, the "field like lower(value)" was suspect. Namely, we were already downcasing the query, but we weren't telling the field to be treated as lower case. I believe in SQLite and Mysql, LIKE clauses are already assumed to be case agnostic. That is, I think, not the case in Postgresql. In other words, Postgresql needs to be told whether or not to treat the field as lower (or upper) case. With this change, I'm also introducing sanitization of possible "like" characters as part of the query. And, I also note that this method has feature envy; That is to say the method sends lots of messages to `::User`, strongly implying that this method belongs in `::User`
cjcolvar
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, I believe the syntax was less generalize. In
particular, the "field like lower(value)" was suspect. Namely, we were
already downcasing the query, but we weren't telling the field to be
treated as lower case.
I believe in SQLite and Mysql, LIKE clauses are already assumed to be
case agnostic. That is, I think, not the case in Postgresql. In other
words, Postgresql needs to be told whether or not to treat the field as
lower (or upper) case.
With this change, I'm also introducing sanitization of possible "like"
characters as part of the query.
And, I also note that this method has feature envy; That is to say the
method sends lots of messages to
::User, strongly implying that thismethod belongs in
::User@samvera/hyrax-code-reviewers