delegate IIIF Manifest cache key version to presenter #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it turns out `etag` isn't a very good cache key because the default `SolrDocument` doesn't contain this data. using the system/Fedora `#modified_date` is equivalent (has the same weaknesses) but is available on both an actual work instance, and on its index proxy. since this is changing (and should likely change again!), delegate it to the presenter so there's a clear source going forward.
cjcolvar
reviewed
Jul 10, 2020
| it 'returns a string' do | ||
| expect(presenter.version).to be_a String | ||
| end | ||
|
|
There was a problem hiding this comment.
Is it worthwhile to add a test here showing that it updates when the work updates? Maybe something like this?
it 'changes when the work changes' do
expect { work.save }.to change { presenter.version }
end
There was a problem hiding this comment.
I added a PR for this spec. If @no-reply likes it, we'll add it.
There was a problem hiding this comment.
see discussion at #4421 (review)
|
since the backport (#4419) is in, i think we should either merge this as-is and roll forward or revert the backport in the current state of the branches is out-of-line with our branching approach, so we shouldn't let it remain for long. |
|
I'm fine with not holding this up over the suggested test. |
cjcolvar
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out
etagisn't a very good cache key because the defaultSolrDocumentdoesn't contain this data. using the system/Fedora#modified_dateis equivalent (has the same weaknesses) but is available onboth an actual work instance, and on its index proxy.
since this is changing (and should likely change again!), delegate it to the
presenter so there's a clear source going forward.
@samvera/hyrax-code-reviewers