[Backport] Allow for injection of new tabs on edit page #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new code seam allowing for the modification of tab
ordering and the addition (or removal) of tabs on a form by form basis.
The default tab order is moved out of the guts4form view partial and
into a helper.
To modify the default list of tabs in an application override the `form_tabs_for` helper method and make sure it gets loaded
after Hyrax::HyraxHelperBehavoir (by default included in app/helpers/hyrax_helper.rb). For example:
```
module WorksHelper
def form_tabs_for(form:)
super + ["my_new_tab"]
end
end
```
A deprecation warning was added for cases where the view calling
guts4form doesn't pass the tabs local param.
The share tab has not been included in the default tab order because it
wasn't in the view partial. Future work is to simplify the guts4form
partial so share can be treated the same as the other tabs and included
in the default list.
Backport of #4440.
cjcolvar
changed the title
jeremyf
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new code seam allowing for the modification of tab
ordering and the addition (or removal) of tabs on a form by form basis.
The default tab order is moved out of the guts4form view partial and
into a helper.
To modify the default list of tabs in an application override the
form_tabs_forhelper method and make sure it gets loadedafter Hyrax::HyraxHelperBehavoir (by default included in app/helpers/hyrax_helper.rb). For example:
A deprecation warning was added for cases where the view calling
guts4form doesn't pass the tabs local param.
The share tab has not been included in the default tab order because it
wasn't in the view partial. Future work is to simplify the guts4form
partial so share can be treated the same as the other tabs and included
in the default list.
Backport of #4440.
@samvera/hyrax-code-reviewers