Stop triggering autocomplete for non-auto complete fields. Support da… #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta attribute based autocomplete types. Moves to a new autocomplete type choosing system that uses data[autocomplete-type] to declaritively select the type instead of just keying of certain field names. Does not remove the existing functionality, but is a baby step toward depricating it.
houndci-bot
reviewed
Jul 16, 2020
| } else if(type === 'linked') { | ||
| new LinkedData(element, url) | ||
| } else { | ||
| new Default(element, url) |
There was a problem hiding this comment.
Do not use 'new' for side effects no-new
| element, | ||
| url) | ||
| } else if(type === 'linked') { | ||
| new LinkedData(element, url) |
There was a problem hiding this comment.
Do not use 'new' for side effects no-new
| { excluding: exclude } | ||
| ) | ||
| } else if(type === 'resource' ) { | ||
| new Resource( |
There was a problem hiding this comment.
Do not use 'new' for side effects no-new
| let type = element.data('autocomplete-type') | ||
| let exlude = element.data('exclude-work') | ||
| if(type === 'resource' && exclude.length > 0) { | ||
| new Resource( |
There was a problem hiding this comment.
Do not use 'new' for side effects no-new
no-reply
approved these changes
Jul 16, 2020
orangewolf
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ta attribute based autocomplete types.
Moves to a new autocomplete type choosing system that uses data[autocomplete-type] to declaritively select
the type instead of just keying of certain field names. Does not remove the existing functionality, but is
a baby step toward depricating it.
@samvera/hyrax-code-reviewers