Gh 4515 and 4516 batch deactivate #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 241cbed we introduced changes to address accessibility issues reported in #3966. However, the introduced change broke the HTML form field names and the assumed parameters for the [batch processing][1]. This commit reverts that change, but it does not address the accessibility concern raised in #3966. That is for another commit, as I don't know if that other commit is the correct path forward. Closes #4516 Closes #4515 [1]:https://github.com/samvera/hyrax/blob/3c7258c95c1fe6f0fe1537078f3f5f458f211989/app/controllers/concerns/hyrax/collections/accepts_batches.rb#L20-L28
In consultation with @Dananji and following the [guidance of W3.org][1], this commit wraps the forms (or controls) that render the [add_buttom partial][2]. I don't believe that I have access to the accessibility testing software, so this is a bit of a stab in the dark. Note, in some cases I render the fieldset as a direct child of the form, in other cases, I render the fieldset as a container for the table used to present the elements that render the add button partial. This relates to work done in #4160 to address #3966. [1]:https://www.w3.org/WAI/tutorials/forms/grouping/ [2]:https://github.com/samvera/hyrax/blob/d5aa2f9ca802fe670687bb4f7c14ad242c1bacf6/app/views/hyrax/batch_select/_add_button.html.erb#L2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring HTML form field name.
a09812c
In 241cbed we introduced changes to
address accessibility issues reported in #3966. However, the introduced
change broke the HTML form field names and the assumed parameters for
the batch processing.
This commit reverts that change, but it does not address the
accessibility concern raised in #3966. That is for another commit, as I
don't know if that other commit is the correct path forward.
Closes #4516
Closes #4515
Adding fieldset to address like named form inputs
b152637
In consultation with @Dananji and following the guidance of W3.org,
this commit wraps the forms (or controls) that render the
add_buttom partial. I don't believe that I have access to the
accessibility testing software, so this is a bit of a stab in the dark.
Note, in some cases I render the fieldset as a direct child of the form,
in other cases, I render the fieldset as a container for the table used
to present the elements that render the add button partial.
This relates to work done in #4160 to address #3966.
@samvera/hyrax-code-reviewers