Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wings: add support for 'count all of model` #4810

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Wings: add support for 'count all of model` #4810

merged 2 commits into from
Mar 25, 2021

Conversation

no-reply
Copy link
Contributor

reduce failing tests for Valkyrie queries to 11.

related to #3570

some refactors are included in a second commit. maybe some small-ish performance optimizations there, but mostly a lot of changes for code readability. please review with that in mind.

@samvera/hyrax-code-reviewers

@no-reply no-reply added the wings label Mar 18, 2021
@no-reply
Copy link
Contributor Author

@elrayle i wonder if you have thoughts about the issue of Hyrax::ObjectNotFoundError vs Valkryie::Persistence::ObjectNotFoundError.

@no-reply no-reply marked this pull request as draft March 18, 2021 18:56
@no-reply no-reply force-pushed the wings-query branch 2 times, most recently from 189bfad to 7aa9573 Compare March 18, 2021 22:18
@no-reply no-reply marked this pull request as ready for review March 19, 2021 04:02
@no-reply no-reply force-pushed the wings-query branch 2 times, most recently from 2455e2f to 0753fb1 Compare March 24, 2021 17:31
reduce failing tests for Valkyrie queries to 11.

related to #3570
@no-reply no-reply force-pushed the wings-query branch 2 times, most recently from 62d7f25 to fef1d81 Compare March 25, 2021 03:15
maybe some small-ish performance optimizations here, but mostly a lot of changes
for code readability.
Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@elrayle elrayle merged commit 678c114 into master Mar 25, 2021
@elrayle elrayle deleted the wings-query branch March 25, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants