-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valkyrie: use storage adapters for derivatives #5626
Commits on Oct 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d89817b - Browse repository at this point
Copy the full SHA d89817bView commit details -
valkyrie: fix thumbnail indexing, add controller(s) for inline files
- make derivatives a named route for url helpers
Configuration menu - View commit details
-
Copy full SHA for 16742b2 - Browse repository at this point
Copy the full SHA 16742b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdfc615 - Browse repository at this point
Copy the full SHA cdfc615View commit details -
Configuration menu - View commit details
-
Copy full SHA for e208a51 - Browse repository at this point
Copy the full SHA e208a51View commit details -
ValkyrieUpload: don't pass use to storage_adapter#upload
it's not handled correctly, and sometimes passed directly to the underlying process (e.g., shrine)
Configuration menu - View commit details
-
Copy full SHA for eed7f39 - Browse repository at this point
Copy the full SHA eed7f39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e7d8ca - Browse repository at this point
Copy the full SHA 4e7d8caView commit details -
ValkyrieUpload: remove find_or_create_metadata
- restore file_identifier set
Configuration menu - View commit details
-
Copy full SHA for 5442386 - Browse repository at this point
Copy the full SHA 5442386View commit details -
Configuration menu - View commit details
-
Copy full SHA for a56af64 - Browse repository at this point
Copy the full SHA a56af64View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7cfb10 - Browse repository at this point
Copy the full SHA a7cfb10View commit details -
WIP: pull the file metadata from the adapter's query
don't try to infer the id of the file metadata node. these resources are handled differently by different adapters, just making one with a file_identifer set doesn't do the trick. see, e.g., the usage here: https://github.com/samvera/hyrax/blob/main/spec/models/hyrax/file_metadata_spec.rb#L27-L43
Configuration menu - View commit details
-
Copy full SHA for 718925c - Browse repository at this point
Copy the full SHA 718925cView commit details -
refactor Hyrax::ValkyrieUpload as Class to allow instances
all but one of the arguments to `ValkyrieUpload` are arguments to a specific action (an upload), but the `storage_adapter` parameter is more stable and cumbersome to pass per upload. in the default case, this doesn't much matter, but when using one of the alternative adapters (e.g. for derivatives), we can reduce the dependencies for collaborator objects by allowing them to use a preconfigured instance of the upload service. e.g: ```ruby derivatives_uploader.upload(filename: 'test.txt', file_set: my_fs, io: StringIO.new('test')) ``` instead of: ```ruby derivatives_adapter = Hyrax.config.derivatives_storage_adapter Hyrax::ValkyrieUpload.file(filename: 'test.txt', file_set: my_fs, io: StringIO.new('test')) ```
Configuration menu - View commit details
-
Copy full SHA for 3bcf0b9 - Browse repository at this point
Copy the full SHA 3bcf0b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b2972f - Browse repository at this point
Copy the full SHA 3b2972fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b4f8e - Browse repository at this point
Copy the full SHA 36b4f8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 287fd03 - Browse repository at this point
Copy the full SHA 287fd03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56f665b - Browse repository at this point
Copy the full SHA 56f665bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3560820 - Browse repository at this point
Copy the full SHA 3560820View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21fd043 - Browse repository at this point
Copy the full SHA 21fd043View commit details -
Previously the final group of characters was not included in the extracted id.
Configuration menu - View commit details
-
Copy full SHA for a7b5951 - Browse repository at this point
Copy the full SHA a7b5951View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab879f7 - Browse repository at this point
Copy the full SHA ab879f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69fd125 - Browse repository at this point
Copy the full SHA 69fd125View commit details -
Always include has_model as reserved_attribute
Attempting to resave a converted resource resulted in an error due to the attribute setter now being defined by ActiveFedora instead of ActiveTriples.
Configuration menu - View commit details
-
Copy full SHA for 19400e4 - Browse repository at this point
Copy the full SHA 19400e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e4b9ad - Browse repository at this point
Copy the full SHA 1e4b9adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9965082 - Browse repository at this point
Copy the full SHA 9965082View commit details
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 880bfab - Browse repository at this point
Copy the full SHA 880bfabView commit details -
Add mock ids to satisfy services that need ids. Include mock_thumbnail in file_ids thumbnail_path should include the fileset id
Configuration menu - View commit details
-
Copy full SHA for 8e6539e - Browse repository at this point
Copy the full SHA 8e6539eView commit details