Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated methods from CollectionBehavior #5744

Merged
merged 2 commits into from
Mar 8, 2023
Merged

remove deprecated methods from CollectionBehavior #5744

merged 2 commits into from
Mar 8, 2023

Conversation

no-reply
Copy link
Contributor

@samvera/hyrax-code-reviewers

dunn
dunn previously approved these changes Jun 27, 2022
@blancoj blancoj self-assigned this Mar 3, 2023
Copy link
Contributor

@blancoj blancoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I tested it:
(1) As Admin, I created a collection as private
(2) Verified that only I could see it, other users could not
(3) Made it public, verified that other users could see it
(4) Added a work to the collection, and verified that the work was attached to the collection.
(5) I added a sub collection to a collection, verified that the count of sub collections for the collection was accurate.
(6) I did notice that if the sub collection is private and the parent collection is public, and the user does not have privileges to view the sub collection, the user is presented with an item count that includes the private sub collection when viewing the parent collection, which I guess could be a little confusing, but of course that does not have to do with this PR.

@dunn dunn merged commit 4bb3089 into main Mar 8, 2023
@dunn dunn deleted the col-beh-dep branch March 8, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-deprecation Release Notes: Deprecation added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants