correctly derive paths for UploadedFileUploader #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this one could probably benefit from a backport to both the 2.x and 3.x release series. |
dunn
previously approved these changes
Jun 28, 2022
dunn
previously approved these changes
Jun 28, 2022
dunn
approved these changes
Jun 28, 2022
`UploadedFileUploader`'s path generation was extremely fragile. for instance, it would generate an incorrect path if the configuration option didn't end with '/'. to generate a vaild in a system independent way, use `Pathname#/` and then cast back to a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UploadedFileUploader's path generation was extremely fragile. for instance, itwould generate an incorrect path if the configuration option didn't end with
'/'.
to generate a vaild in a system independent way, use
Pathname#/and then castback to a string.
@samvera/hyrax-code-reviewers