retain the default listeners for future unsubscribing #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Jul 19, 2022
|
|
||
| ## | ||
| # @return Array[Object] the listeners Hyrax subscribes by default. | ||
| def default_listeners |
There was a problem hiding this comment.
How about adding a simple test since this is a public thing which shouldn't go away without red flags?
Maybe something ensuring it returns an array?
There was a problem hiding this comment.
tests are in. thanks!
no-reply
force-pushed
the
retain-default-listeners
branch
from
37f73d6
to
141d96d
Compare
subscribe the hyrax default listeners in batch. provide a hook for looking up the `Hyrax.publisher.default_listeners`. this makes it possible to unsubscribe individual listeners at a later time. these instances have to live in memory for the life of the Publisher anyway, so this shouldn't impact when they are freed for garbage collection.
no-reply
force-pushed
the
retain-default-listeners
branch
from
141d96d
to
5af0f63
Compare
|
this one had fallen way behind, but i just rebased it and will follow through on any issues in the tests. |
dunn
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscribe the hyrax default listeners in batch. provide a hook for looking up
the
Hyrax.publisher.default_listeners. this makes it possible to unsubscribeindividual listeners at a later time.
these instances have to live in memory for the life of the Publisher anyway, so
this shouldn't impact when they are freed for garbage collection.
@samvera/hyrax-code-reviewers