raise a useful error when setting an unknown visibility #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
keyerror-visibility
branch
from
8e4ef64
to
7790b45
Compare
|
related to #5572 |
when a user tries to set a visilibity we don't know about, don't respond with `NoMethodError` on `nil`, but give a useful error message that hints at what has gone wrong.
no-reply
force-pushed
the
keyerror-visibility
branch
from
7790b45
to
7c8f014
Compare
dlpierce
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a user tries to set a visilibity we don't know about, don't respond with
NoMethodErroronnil, but give a useful error message that hints at what hasgone wrong.
@samvera/hyrax-code-reviewers