provide default PermissionBadge presenter behavior when nil
#5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if visibility wasn't indexed for any item, the `PermissionBadge` presenter will cause any relevant page not to render. this fixes that issue by providing a reasonable default display badge in the case that we can't identify the visibility from the indexed data.
no-reply
force-pushed
the
permission-badge-default
branch
from
9605c44
to
32497c0
Compare
dunn
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if visibility wasn't indexed for any item, the
PermissionBadgepresenter willcause any relevant page not to render.
this fixes that issue by providing a reasonable default display badge in the
case that we can't identify the visibility from the indexed data.
@samvera/hyrax-code-reviewers