Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soften dependendy on search_state_class for app generation #5808

Merged
merged 2 commits into from
Aug 23, 2022
Merged

soften dependendy on search_state_class for app generation #5808

merged 2 commits into from
Aug 23, 2022

Conversation

no-reply
Copy link
Contributor

search_state_class isn't defined on CatalogController until after blacklight
generator has run, but Hyrax::Engine needs to execute before that in
generation.

cc @cjcolvar

@samvera/hyrax-code-reviewers

@cjcolvar
soften dependendy on search_state_class for app generation
c4eb7d8 
search_state_class isn't defined on CatalogController until after blacklight
generator has run, but `Hyrax::Engine` needs to execute before that in
generation.
@cjcolvar
Copy link
Member

I missed that @dlpierce had already opened a PR (#5802) to cherry-pick this commit into main, but that PR didn't pass the test app generation. Looks like this one failed in the same spot. I think eead121 should resolve the issue.

@no-reply
Copy link
Contributor Author

thanks! cherry picked that one here too

@no-reply
Copy link
Contributor Author

this looks hopeful!

@no-reply no-reply merged commit bf5df6f into main Aug 23, 2022
@no-reply no-reply deleted the search_state_class-soft-dependency branch August 23, 2022 18:13
@dlpierce
Copy link
Contributor

Thanks, both of you!

@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no-reply @cjcolvar @dlpierce