Improving file handle life cycle #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What follows is speculation, but informed by the [File.open documentation][1].
Prior to this commit, there was no guarantee that once we opened a file,
we would close it. This means that as this process ran we could
accumulate open file handles on the system.
By switching to the `File.open { |file| ... }` approach the
aforementioned block will ensure that we close the file when the block
terminates.
Note: This came about in trying to debug the callstack for
[ruby2-6 (65220) - samvera/hyrax][2]
[1]:https://ruby-doc.org/core-2.7.2/File.html#method-c-open
[2]:https://app.circleci.com/pipelines/github/samvera/hyrax/8274/workflows/26246722-a8e8-43a0-a1fa-7b32db139856/jobs/65220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What follows is speculation, but informed by the File.open documentation.
Prior to this commit, there was no guarantee that once we opened a file,
we would close it. This means that as this process ran we could
accumulate open file handles on the system.
By switching to the
File.open { |file| ... }approach theaforementioned block will ensure that we close the file when the block
terminates.
Note: This came about in trying to debug the callstack for
ruby2-6 (65220) - samvera/hyrax
@samvera/hyrax-code-reviewers