Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FileSetsController to access the presenter and deprecate FileSetBehavior#to_presenter #5895

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Use FileSetsController to access the presenter and deprecate FileSetBehavior#to_presenter #5895

merged 1 commit into from
Oct 12, 2022

Conversation

dlpierce
Copy link
Contributor

Alternative to #5890

Ensures @presenter is available to views in the Hyrax::FileSetsController and uses it to access the solr doc instead of the poorly named FileSet model method to_presenter that was actually returning a solr doc.

@no-reply no-reply merged commit 5eabdeb into main Oct 12, 2022
@no-reply no-reply deleted the deprecate_to_presenter branch October 12, 2022 17:42
@dlpierce dlpierce added the notes-deprecation Release Notes: Deprecation added label Oct 12, 2022
@marrus-sh marrus-sh mentioned this pull request Oct 12, 2022
Merged
@marrus-sh marrus-sh mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrus-sh marrus-sh marrus-sh approved these changes

@no-reply no-reply Awaiting requested review from no-reply

Assignees
No one assigned
Labels
notes-deprecation Release Notes: Deprecation added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlpierce @marrus-sh @no-reply