Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Samvera Slack badge in README #5931

Merged
merged 2 commits into from
Dec 13, 2022
Merged

fix Samvera Slack badge in README #5931

merged 2 commits into from
Dec 13, 2022

Conversation

bkiahstroud
Copy link
Contributor

Fix the Samvera Slack badge in the README.

There were two issues with the existing Slack badge:

  • The badge did not render correctly, showing a text link instead
  • The link did not link to the correct URL

samverahyrax at fix-slack-badge-in-readme 2022-12-12 at 8 59 22 AM

@samvera/hyrax-code-reviewers

K8Sewell
K8Sewell previously approved these changes Dec 12, 2022
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on that url being bad!
I think the switch to the slack.com url is good.
In theory the samvera.org link should still work so @heathergreerklein is taking a look at it since it is used in most other repositories.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@heathergreerklein
Copy link
Contributor

Fixed this on the DNS so that http://slack.samvera.org will also redirect to samvera.slack.com

@cjcolvar cjcolvar merged commit fd2f525 into main Dec 13, 2022
@cjcolvar cjcolvar deleted the fix-slack-badge-in-readme branch December 13, 2022 17:45
@dlpierce dlpierce added the notes-docs Release Notes: Documentation label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-docs Release Notes: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants