Fix method not found error for File analytics page #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
force-pushed
the
5955-file-analytics
branch
from
5026cb2
to
e5e20f3
Compare
…eview and hyrax_download methods
dlpierce
force-pushed
the
5955-file-analytics
branch
from
e5e20f3
to
648890f
Compare
orangewolf
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix method not found error for File analytics page by using hyrax_pageview and hyrax_download methods
Fixes #5955
As described in the ticket, the File analytics page is throwing an error in hyrax 3 and 4. It can be verified on nurax. The change in this PR resolves the problem in my local repository.
It looks like file_download_stat.rb and statistic.rb used these methods at one point, so I do not know if there is a good reason not to use them.
https://github.com/samvera/hyrax/pull/5089/files#diff-5b2a56b95bdff9c7fa8cc57e7444e3b10f7dc22f45aa739805e49cb19ae93d0fL15
@samvera/hyrax-code-reviewers @orangewolf @alishaevn @sara-g @no-reply