Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to CircleCI config #5981

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Updates to CircleCI config #5981

merged 3 commits into from
Mar 10, 2023

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Mar 9, 2023

Fixes broken build caused by mismatch between gems installed for the hyrax engine versus the generated .internal_test_app. This is solved by running bundle install for the internal_test_app using the ruby orb to allow the target directory to be set.

Also contains these other changes:

  • Remove outdated nurax deployment workflow
  • Run yarn install with caching for both the engine and test app
  • Be more specific with rubocop caching
  • Updated default ruby/bundler/rails versions
  • Drop ruby patch version from workflow and job names (will need to update required checks)
  • Use rspec-test command provided by ruby orb
  • Reduce resource_class of bundle and build jobs
  • Store both Gemfile.lock files as artifacts

@samvera/hyrax-code-reviewers

@dlpierce dlpierce requested a review from cjcolvar March 9, 2023 21:00
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain more about the reason or value or switching to ruby/rspec-test from samvera/parallel_rspec?

With the use of ruby/install-deps, node/install-packages, and ruby/rspec-test, I'm wondering if the samvera orb supplied commands that aren't idiosyncratic are still useful. The samvera orb met a need before, but maybe the standard orbs can meet our needs and have actually matured past the orb such that it would be a benefit to switch to them (in terms of increased functionality, robustness, and ongoing maintenance). I guess all of this is to ask if you envision Hyrax's use of orbs to be shifting and the Samvera orb should adapt accordingly?

At face value all of these changes look fine.

@dlpierce
Copy link
Contributor Author

From what I could tell the other orbs were not available when the samvera orb was being created, so yes I do think they have evolved past the change abilities of our orb. Ours is certainly still useful for the engine cart command and the executors.

In the case of rspec-test, yes it is to hopefully reduce needed maintenance. I expect the ruby orb would be updated in the event Circle changes how tests are split or results reported.

For ruby/install-deps it allows using a different Gemfile than the default, a capability the Samvera orb lacks. Perhaps a version 2.x of the samvera orb could wrap the ruby orb command? That would allow us to retain the extra checksummed files used for the cache key.

I still had to call yarn install directly for the engine in order to use caching.

@dlpierce dlpierce merged commit 0ca3d30 into main Mar 10, 2023
@dlpierce dlpierce deleted the circleci-exp branch March 10, 2023 17:19
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants