Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kaminari_route_prefix gem with initializer patch #6048

Merged
merged 1 commit into from
May 1, 2023

Conversation

dlpierce
Copy link
Contributor

Fixes spec/views/hyrax/users/index.html.erb_spec.rb on Ruby 3

kaminari_route_prefix is not Ruby 3 compatible, and the engine routing feature it supplies is (still!) not part of kaminari core. This replaces it with an in-tree patch. The changes to views are not included as they seem unused in hyrax.

Changes proposed in this pull request:

  • Remove kaminari_route_prefix gem
  • Add initializer patch to support the route_set option for paginate

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Pages that use kaminari pagination still function as expected

@samvera/hyrax-code-reviewers

Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this. barely 10 lines of inline code replacing an entire dependency is always a good call as far as i'm concerned

@no-reply no-reply merged commit 117aa44 into main May 1, 2023
@no-reply no-reply deleted the kaminari-engine-patch branch May 1, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants