Migrate LockManager to #then for better ConnectionPool support #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
redis-pool-semantics
branch
2 times, most recently
from
223487f
to
97de518
Compare
no-reply
force-pushed
the
redis-pool-semantics
branch
from
97de518
to
66c3216
Compare
drops `LockManager#client` from the public API. this isn't used in Hyrax, but we should sneak this into 4.0 so we don't have to figure out a hack to return a stable client from here without `Redis.current` support
dlpierce
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drops
LockManager#clientfrom the public API. this isn't used in Hyrax, but weshould sneak this into 4.0 so we don't have to figure out a hack to return a
stable client from here without
Redis.currentsupport@samvera/hyrax-code-reviewers