add extension behavior for FileSet show view partials #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
requested changes
May 25, 2023
Comment on lines
+14
to
+16
| <% @presenter.show_partials.each do |partial_path| %> | ||
| <%= render partial_path %> | ||
| <% end %> |
There was a problem hiding this comment.
Suggested change
| <% @presenter.show_partials.each do |partial_path| %> | |
| <%= render partial_path %> | |
| <% end %> | |
| <% @presenter.show_partials.each do |partial_path| %> | |
| <%= render partial_path %> | |
| <% end %> |
There was a problem hiding this comment.
@alishaevn i don't think we want to nest indentation here? that will result in the partial HTML content being indented a level too far (since the #each block won't appear in the rendered HTML).
added 2 commits
June 14, 2023 16:46
if a user wants to extend the FileSet show view to, e.g. show file specific details or relationships to other objects, they should be able to inject that behavior here. extensions were vaguely waved at around Sufia 7: samvera-deprecated/sufia#1481 we have some in mind in Surfliner: https://gitlab.com/surfliner/surfliner/-/issues/1282
no-reply
force-pushed
the
file_set-show-descriptions
branch
from
6655158
to
45f4ed8
Compare
alishaevn
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a user wants to extend the FileSet show view to, e.g. show file specific
details or relationships to other objects, they should be able to inject that
behavior via the presenter
extensions were vaguely waved at around Sufia 7:
samvera-deprecated/sufia#1481
we have some in mind in Surfliner:
https://gitlab.com/surfliner/surfliner/-/issues/1282
Changes proposed in this pull request:
FileSetPresenter#show_partialsto list partial paths to render in the guts of the FileSet show page.Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers