#5567 View All Collections button #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…man readable type
aprilrieger
approved these changes
May 31, 2023
alishaevn
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co-author: @sephirothkod
Fixes
Summary
The View all Collections button on the homepage was broken - it was using
human_readable_typeto search instead ofgeneric_type.generic_typesearches for all collections with both regular hyrax & with valkyrized hyrax, so this update will make the button compatible for users with both setups.this change is based on a comment from @no-reply that suggested
generic_typeto be more backwards compatibleType of change (for release notes)
Changes proposed in this pull request:
generic_typeto search for collections from the homepage "View All Collections" button instead ofhuman_readable_typesince it is compatible with both regular and valkyrized hyrax.@samvera/hyrax-code-reviewers