-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5575 item actions edit #6090
5575 item actions edit #6090
Conversation
there was an error because `#representative_id=` did not exist. refer to #5575 for more details. co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
d6aa7b1
to
c12b8fc
Compare
the license attribute is not required in Hyrax::Forms::WorkForm and is not even available as an editable field on the Hyrax::Forms::FileSetForm. so it feels unnecessary to require it on file sets. co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
@@ -16,7 +16,7 @@ attributes: | |||
type: string | |||
multiple: true | |||
form: | |||
required: true | |||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the license attribute is not required in Hyrax::Forms::WorkForm and isn't even available as an editable field on the Hyrax::Forms::FileSetForm, so @sephirothkod and I decided it was unnecessary to require for file sets. removing that requirement allowed change_set.validate(attributes) in Hyrax::FileSetsController#update_metadata to work.
ref: (two different comments)
@@ -6,7 +6,7 @@ class FileSetEditForm | |||
|
|||
delegate :depositor, :permissions, :human_readable_type, to: :model | |||
|
|||
self.required_fields = [:title, :creator, :license] | |||
self.required_fields = [:title, :creator] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the license attribute is not required in Hyrax::Forms::WorkForm and isn't even available as an editable field on the Hyrax::Forms::FileSetForm, so @sephirothkod and I decided it was unnecessary to require for file sets. removing that requirement allowed change_set.validate(attributes) in Hyrax::FileSetsController#update_metadata to work.
ref: (two different comments)
the |
Fixes
Summary
fix the ability to edit valkyrie backed file sets
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
Detailed Description
there was an error because
#representative_id=
did not exist. refer to https://github.com/samvera/hyrax/issues/5575\#issuecomment-1581512555 for more details@samvera/hyrax-code-reviewers