thumbnails and other derivatives were not stored in the path we expected them to be #6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted them to be. this was due to Valkyrie using a different pairtree method than Hyrax
orangewolf
force-pushed
the
5504-deriviatives-were-harder-to-find-than-wifes-headphones
branch
from
b7ebda3
to
fa1be2b
Compare
orangewolf
commented
Jun 10, 2023
| @@ -0,0 +1,25 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
I would have subclassed the override here but Valkyrie::Storage::Disk::BucketStorage is a inner class. That makes me think it is best to replace instead of extend.
orangewolf
commented
Jun 10, 2023
| tmpfile.write stream.read | ||
| stream.rewind | ||
| output = tmpfile.write(stream.read) | ||
| tmpfile.flush |
There was a problem hiding this comment.
the adapter does not flush the buffer first, so we need to make absolutely sure the file is in the tmp location.
alishaevn
changed the title
dlpierce
approved these changes
Jun 12, 2023
dlpierce
deleted the
5504-deriviatives-were-harder-to-find-than-wifes-headphones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Derivatives were stored in a pairtree using the first 5 non-dash items. But Hyrax expects them to be stored in a pairtree of the full id. This mismatch meant no derivatives could be found properly.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
@samvera/hyrax-code-reviewers