5844-set-embargo-date-as-datetime #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. this way it will match the data type of the same value on dassie embargoes
alishaevn
added
notes-valkyrie
…argo to the resource!
alishaevn
force-pushed
the
5844-set-embargo-date-as-datetime
branch
from
d48eb4d
to
6f82927
Compare
…_date`. idk if this will actually change anything, but some of the flaky specs in "spec/controllers/hyrax/dashboard/collections_controller_with_resource_spec.rb" are complaining about `to_datetime` not existing for some reason.
summer-cook
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
save the
embargo_release_dateproperty as a DateTime instead of String. this way it will match the data type of the same value on dassie embargoes.demo
Detailed Description
when creating a new work with an embargo,
params['<work-type>']['embargo_release_date']is aYYYY-MM-DDstring in both dassie and koppie. so somewhere down the line we must be converting it to a DateTime in dassie.I started going deep into the stack trace then decided to come back and just see if I could update the attribute from a string to date time before we save the embargo
@samvera/hyrax-code-reviewers