inline collections_controller_resource_spec to existing tests #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dashboard/collections_controller_resource_spec` is a slightly divergent copy-paste of the same tests in `dashboard/collections_controller_spec`. this creates a major maintenance burden, and some weird misdirection when navigating the codebase (how will i know to look for tests on the Controller here?). the more immediate problem is that this whole test setup is flaky and the whole file can fail en masse. as a first step(?) for a fix, we want to inline all the tests so they run identically and setup for both sets of specs is in one place. this is a straight inline, removing the duplicate tests. some attention was given to resolving drift between the specs.
no-reply
force-pushed
the
collection-controller-resource
branch
from
2bcd500
to
538db6e
Compare
VivianChu
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dashboard/collections_controller_resource_specis a slightly divergent copy-paste of the same tests indashboard/collections_controller_spec. this creates a major maintenance burden, and some weird misdirection when navigating the codebase (how will i know to look for tests on the Controller here?).the more immediate problem is that this whole test setup is flaky and the whole file can fail en masse.
as a first step(?) for a fix, we want to inline all the tests so they run identically and setup for both sets of specs is in one place. this is a straight inline, removing the duplicate tests. some attention was given to resolving drift between the specs.
@samvera/hyrax-code-reviewers