Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valkyrize batch editing #6148

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Valkyrize batch editing #6148

merged 10 commits into from
Aug 22, 2023

Commits on Aug 21, 2023

  1. Valkyrize batch editing

    @cjcolvar
    cjcolvar authored and tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    17b9f7e View commit details
    Browse the repository at this point in the history

  2. wings: provide a convenience method DefaultWork#file_sets 

    Hydra works has this, and it will be nice to provide it to Wings users handling
Valkyrie native models cast back to AF.
    tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    cf502da View commit details
    Browse the repository at this point in the history

  3. refactor some specs to avoid LDP errors during test setup 

    i don't know why these older tests run into LDP errors during setup after the
rewrite in 361b113, but we don't want to use these factories in setup anyway.

since the issue occurs before any production code is executed, it's safe to just
refactor to setup using the Valkyrie based factories. we'll want to complete
this refactor throughout this file anyway.
    tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    356b0b7 View commit details
    Browse the repository at this point in the history

  4. Fix failed controller tests for batch edit.

    @lsitu
    lsitu authored and tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    df8e737 View commit details
    Browse the repository at this point in the history

  5. Fix the inconsistent param_key issue.

    @lsitu
    lsitu authored and tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9f82151 View commit details
    Browse the repository at this point in the history

  6. Add column_for_attribute for active fedora compatibility.

    @lsitu
    lsitu authored and tamsin johnson committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bfc509c View commit details
    Browse the repository at this point in the history

  7. Clean up valkyrie form fields to avoid transaction errors: 

    * Fix transaction error undefined method `<' for nil:NilClass

* Fix transaction error implicit conversion of Symbol into Integer.

* Refactor to fix lint error with the Metrics/AbcSize cop.
    @lsitu
    lsitu committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    49a5c9e View commit details
    Browse the repository at this point in the history

  8. Correct permissions_attributes value format.

    @lsitu
    lsitu committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8dfb21e View commit details
    Browse the repository at this point in the history

  9. Fix failed integration tests for valkyrie.

    @lsitu
    lsitu committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6f3099a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge branch 'main' into valk-batch-edit-old

    @tpendragon
    tpendragon authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6b2c3ba View commit details
    Browse the repository at this point in the history