Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie publish file.characterized event for derivative creation #6180

Merged
merged 4 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/jobs/valkyrie_ingest_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ def perform(file, pcdm_use: Hyrax::FileMetadata::Use::ORIGINAL_FILE)
def ingest(file:, pcdm_use:)
file_set_uri = Valkyrie::ID.new(file.file_set_uri)
file_set = Hyrax.query_service.find_by(id: file_set_uri)
updated_metadata = upload_file(
upload_file(
file: file,
file_set: file_set,
pcdm_use: pcdm_use,
user: file.user
)

ValkyrieCreateDerivativesJob.perform_later(file_set.id.to_s, updated_metadata.id.to_s)
end

##
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ def self.run(metadata:, file:, user: ::User.system_user, **options)
new(metadata: metadata, file: file, **options).characterize
saved = Hyrax.persister.save(resource: metadata)
Hyrax.publisher.publish('file.metadata.updated', metadata: saved, user: user)

Hyrax.publisher.publish('file.characterized',
file_set: Hyrax.query_service.find_by(id: saved.file_set_id),
file_id: saved.id.to_s,
path_hint: saved.file_identifier.to_s)
end

##
Expand Down
16 changes: 13 additions & 3 deletions app/services/hyrax/listeners/file_metadata_listener.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,16 @@ class FileMetadataListener
# @param [Dry::Events::Event] event
# @return [void]
def on_file_characterized(event)
CreateDerivativesJob
.perform_later(event[:file_set], event[:file_id], event[:path_hint])
file_set = event[:file_set]

case file_set
when ActiveFedora::Base # ActiveFedora
CreateDerivativesJob
.perform_later(file_set, event[:file_id], event[:path_hint])
else
ValkyrieCreateDerivativesJob
.perform_later(file_set.id.to_s, event[:file_id])
end
end

##
Expand All @@ -39,7 +47,9 @@ def on_file_metadata_updated(event)
# @param [Dry::Events::Event] event
# @return [void]
def on_file_uploaded(event)
# Run characterization
# Run characterization for original file only
return unless event[:metadata]&.original_file?

Hyrax.config
.characterization_service
.run(metadata: event[:metadata], file: event[:metadata].file)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
original_filename: 'test_world.png')
end

before { Hyrax.publisher.subscribe(listener) }
before do
Hyrax.publisher.subscribe(listener)
metadata.file_set_id = file_set.id
end
after { Hyrax.publisher.unsubscribe(listener) }

describe '#run' do
Expand Down