update CollectionType GlobalID update task to use valkyrie #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
col-gid-task
branch
2 times, most recently
from
bd41e8a
to
4e9501f
Compare
dunn
previously approved these changes
Aug 29, 2023
PcdmCollection cannot handle the `force: true` argument supplied by the rake task, so move it to a thread local var for this special case. This is rather hacky, but avoids using a property and cluttering the data model. Using an instance variable to store the force state does not work in wings because it rebuilds the object from attributes when persisting.
dlpierce
force-pushed
the
col-gid-task
branch
from
6f50f62
to
389bb3c
Compare
tpendragon
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i considered removing this task, but it was easy to rewrite and Hyrax still supports lookup for both GlobalID styles
@samvera/hyrax-code-reviewers