Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Hyrax::RoleManagement from .koppie #6272

Merged
merged 1 commit into from
Aug 30, 2023
Merged

remove Hyrax::RoleManagement from .koppie #6272

merged 1 commit into from
Aug 30, 2023

Conversation

no-reply
Copy link
Contributor

including this makes the whole application very different from .dassie, in a way that complicates the test suite substantially.

@samvera/hyrax-code-reviewers

remove Hyrax::RoleManagement from .koppie
a205d16 
including this makes the whole application very different from `.dassie`, in a
way that complicates the test suite substantially.
@no-reply no-reply added notes-valkyrie Release Notes: Valkyrie specific notes-container Release Notes: Docker, Helm, etc labels Aug 30, 2023
@no-reply no-reply requested a review from dlpierce August 30, 2023 21:53
dlpierce
dlpierce approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I expect it will be retained for nurax pg.

@dlpierce dlpierce merged commit eb79277 into main Aug 30, 2023
3 checks passed
@dlpierce dlpierce deleted the no-role-mgmt branch August 30, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpierce dlpierce dlpierce approved these changes

Assignees
No one assigned
Labels
notes-container Release Notes: Docker, Helm, etc notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no-reply @dlpierce