Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Valkyrie for test setup on Collections:PremissionsService specs #6274

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

no-reply
Copy link
Contributor

remove a lot of AF stubs and replace them with real setup using valkyrie.

Fixes #6254

@samvera/hyrax-code-reviewers

@no-reply no-reply added notes-valkyrie Release Notes: Valkyrie specific notes-tests Release Notes: Spec or CI changes labels Aug 31, 2023
Copy link
Contributor

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice improvement to this test. I ran it locally and it passes now.

remove a lot of AF stubs and replace them with real setup using valkyrie.
@no-reply no-reply merged commit 08d3534 into main Aug 31, 2023
3 checks passed
@no-reply no-reply deleted the perm-serv branch August 31, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-tests Release Notes: Spec or CI changes notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure spec/services/hyrax/collection_types/permissions_service_spec.rb passes on .koppie
2 participants