Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional aria-labels to form elements #6328

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Add additional aria-labels to form elements #6328

merged 5 commits into from
Sep 21, 2023

Conversation

bbpennel
Copy link
Contributor

Fixes

Committing back local overrides

Summary

Adds aria-labels to a few form components based on accessibility work in our local repository

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Use the WAVE plugin to check for missing aria labels on the work create/editing page to see if the embargo/lease options have labels with this PR. Check the main search form, and the search form on the "my works" page.

Type of change (for release notes)

notes-bugfix - Add additional missing aria-labels

Detailed Description

Committing back a few aria-labels that we had added to our local repository after doing an accessibility survey.

Changes proposed in this pull request:

  • Adds missing aria-label attributes.

@samvera/hyrax-code-reviewers

Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your local fixes!

@bbpennel bbpennel merged commit f14958e into main Sep 21, 2023
@bbpennel bbpennel deleted the unc-aria-labels branch September 21, 2023 13:31
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants