Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6333
Summary
In valkyrie/fedora, deleting a work results in an error. The underlying issue is the application attempting to re-access a work on Fedora after it was deleted.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
notes-bugfix
Bug FixesDetailed Description
A work deletion executes two transactions:
In the previous ordering of these transactions, a work resource is deleted in Fedora, and then access to the resource is re-attempted when the
work_resource.delete_acl
transaction is processing. Specifically,work_resource.delete_acl
involves finding the ACL usingfind_access_control_for(resource:)
inapp/services/hyrax/custom_queries/find_access_control.rb
, which attempts to load the resource (work) on Fedora through Valkyrie. When a resource is deleted on Fedora and then an access is attempted, Fedora returns the error:Discovered tombstone resource at ...
.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers