-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a permissive schema to the Fedora Valkyrie adapter (#6332). #6338
Conversation
Looking good. Some fields are still given the "example.com/predicate" schema, mostly the internal attributes that are defined outside of the metadata yaml files. What do you think of having a specially named yaml file that only defines the predicates for those internal attributes? I guess it would look like: id:
predicate: http://purl.org/dc/terms/identifier
internal_resource:
predicate: ??? |
Also, I see the simple schema loader will not redefine an existing predicate pair, but perhaps that should raise an error or at least log a warning? |
@dlpierce Yeah, I saw that. Is there a good location for all of those internal attributes? Wanna knock them all out if I can. As far as the simple schema loader not redefining the predicate pair--I did that on purpose, since the YAML files from the main application comes first, effectively overriding any predicates that are defined in the Hyrax engine. I can throw a Rails log warning every time a predicate has the potential of being overwritten, if you'd like. |
|
@dlpierce Ready for another look. |
2782245
to
ac4fbf8
Compare
Basic and core metadata match up with the predicates I know about from SMIG and the Metadata Application Profile. Collection metadata also seems to match up to basic metadata properties and that is what we want to use. I'm not so sure about file set metadata or hyrax internal metadata, but the predicates assigned seem like they would be OK to use if I understand the properties being defined. |
Fixes
Fixes #6332
Summary
Processes predicates from metadata YAMLs for permissive schema.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
docker compose -f docker-compose-sirenia.yml up
)localhost:3002
).creator
,dateSubmitted
,modified
, andtitle
all contain the letters "dc".Type of change (for release notes)
notes-valkyrie
Valkyrie ProgressDetailed Description
Our Basic and Core Metadata terms didn't have their predicates carry over when we transitioned to Valkyrie from ActiveFedora. This code implements the assigning of predicates in the Metadata YAMLs and logic to build the permissive schema required to pass to the Fedora adapter.
Changes proposed in this pull request:
Hyrax::SimpleSchemaLoader
method to populate a schema hash for the Fedora Valkyrie adapter.@samvera/hyrax-code-reviewers