Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fileset representative_id and thumbnail_id readonly in form #6355

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Make fileset representative_id and thumbnail_id readonly in form #6355

merged 1 commit into from
Oct 10, 2023

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Oct 9, 2023

Fixes

Fixes #6351

Summary

These are not settable file set fields, reflect that in the form.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Able to edit file set and upload new file versions

Changes proposed in this pull request:

  • Set represetative_id and thumbnail_id to writeable: false in the form
  • Remove compatibility method that patched this for representative_id previously

@samvera/hyrax-code-reviewers

@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Oct 9, 2023
@dlpierce dlpierce merged commit 191c31a into main Oct 10, 2023
4 checks passed
@dlpierce dlpierce deleted the valk-fix-add-file-version branch October 10, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatson78 bwatson78 bwatson78 approved these changes

Assignees
No one assigned
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uploading a new version of a file gives "there was a problem processing your request" error
2 participants
@dlpierce @bwatson78