Use a hashed version identifier in IIIF manifest #6368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
force-pushed
the
versioned_riiif
branch
from
dddd348
to
1d4da16
Compare
Ensures the IIIF server can discern outdated image data in the event of a file revision. Summary of changes: - Add RiiifFileResolver and RiiifFile to more efficiently use riiif with valkyrie storage adapters. Uses a read/write lock when loading a local file copy from storage. - Rerun characterization/derivatives when reverting a file version. - Include version in solr indexed original_file_id. This is now generated by Hyrax::FileSet#iiif_id instead of in the indexer. - Patch valkyrie StreamFile length in same manner as ::File. - Set json content type for manifest response. - The :test_disk storage adapter for specs is now a VersionedDisk adapter.
…here is no file_identifier
dlpierce
force-pushed
the
versioned_riiif
branch
from
1d4da16
to
3f32be7
Compare
dlpierce
added
notes-minor
abelemlih
reviewed
Oct 19, 2023
abelemlih
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6352
Summary
Ensures the IIIF server can discern outdated image data in the event of a file revision.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Details
Despite its name, the Riiif::HttpFileResolver was capable of opening files available on a local filesytem. In doing so it would create its own copy of the file based on the id less any version data. In the event of a file revision, the cached file could not be easily cleared.
This prompted a new resolver that interfaces with valkyrie storage adapters more directly. This avoids the extraneous file copy, and attempts to prevent riiif from transforming files that have not finished copying via a Concurrent::ReadWriteLock.
The version portion of the image identifiers in the IIIF manifest is hashed to avoid potentially overly verbose version strings.
Changes proposed in this pull request: