Fix user links menu running off right side of page #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he side of the page with short user names
dlpierce
force-pushed
the
user_links_sidebar_fixes
branch
from
6d1250d
to
8598bae
Compare
dlpierce
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In hyrax 4 or 5, when the user's username is very short (particularly when username's are not email addresses) the dropdown menu containing user links in the top right corner will run off the right side of the screen.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Log in to nurax or dassie with a user with a very short name, such as "b@b.b", or admin if you are not using a scheme that requires email addresses as the username.
Type of change (for release notes)
notes-bugfix
Detailed Description
N/A
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers