Fix embargo expiry job spec #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks existing spec as AF only. Duplicates existing EmbargoExpiryJob specs but with Valkyrie resources. Spec setup is simplified by not specifying "restricted" visibility, instead expecting the factory default "authenticated". Additional checks to confirm the initial visibility state are also added. The embargo traits from the hyrax_work factory are copied to the hyrax_file_set factory. Saving of the expired embargo ACL is moved to inside the time machine to 10 days ago. Without this change the solr doc will not contain the embargo related fields, causing `#records_with_expired_embargoes` to not find those resources.
dlpierce
added
notes-valkyrie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add valkyrie specs for EmbargoExpiryJob
Marks existing spec as AF only.
Duplicates existing EmbargoExpiryJob specs but with Valkyrie resources.
Spec setup is simplified by not specifying "restricted" visibility, instead expecting the factory
default "authenticated". Additional checks to confirm the initial visibility state are also added.
The embargo traits from the hyrax_work factory are copied to the hyrax_file_set factory.
Saving of the expired embargo ACL is moved to inside the time machine to 10 days ago. Without this
change the solr doc will not contain the embargo related fields, causing
#records_with_expired_embargoesto not find those resources.