Updates lease_service_spec.rb for valkyrie. #6436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatson78
force-pushed
the
fixes_lease_service_spec
branch
from
93db484
to
d526766
Compare
|
I think making use of Hyrax::TimeService to perform the indexing in the past can help resolve the problem of no expired lease data being indexed. However, there is also #6330 that has been waiting to get finished up and may impact how this spec is fixed up. Then embargo_service_spec.rb can likely share in the fixes given the similarities of leases and embargoes. |
bwatson78
force-pushed
the
fixes_lease_service_spec
branch
3 times, most recently
from
2192970
to
98880e1
Compare
bwatson78
force-pushed
the
fixes_lease_service_spec
branch
from
98880e1
to
d68c68a
Compare
bwatson78
force-pushed
the
fixes_lease_service_spec
branch
from
d68c68a
to
aaf960c
Compare
|
As expected, merging 6330 caused some conflicts. |
|
@dlpierce The just merged lease work hasn't affected the behavior shown in the tests. |
dlpierce
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/services/hyrax/lease_service_spec.rbSummary
Updates lease_service_spec.rb for valkyrie.
Type of change (for release notes)
notes-valkyrieValkyrie Progress@samvera/hyrax-code-reviewers
Note: it may cause problems that the LeaseService relies on Solr instead of querying the actual objects.