Collection Location field fixes; Valkyrize collection dashboard feature spec #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
added
notes-minor
The old AdminSet form outputs a string, new AdministrativeSet form an array.
CollectionResource includes some properties that are expected by specs (description, based_near, etc)
Instead of using a large list of attributes that *almost* match basic metadata, use the basic metadata schema as suggested in the generated collection metadata schema config. The significant differences for koppie are creator becomes a required form field, and some fields are secondary instead of primary. Real applications are still free to customize their collection model as desired.
This is for both ActiveFedora and Valkyrie models. Old string values should still be compatible. Fixes missing prepopulated location field on new forms.
…specs This allows CollectionResource to be used when converting from AF, and PcdmCollection to still map to Collection. Does not affect operation outside of specs.
dlpierce
force-pushed
the
valk-dash-col-feat-spec
branch
from
df37f6a
to
b270d43
Compare
bwatson78
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #5155 ; refs #3819
Summary
Improves support for the collection location field.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Detailed Description
This epic began with the goal of updating
spec/features/dashboard/collection_spec.rbfor valkyrie compatibility. However, due to differences in collection metadata in the establishedCollectionandHyrax::PcdmCollectionmodels for dassie and koppie respectively, it became clear that the:hyrax_collectionfactory needed some changes.Fields such as description and based_near are expected by the spec, but were not available on the bare bones
Hyrax::PcdmCollectionmodel generated by the hyrax_collection factory. The generated CollectionResource model is already present, although with some slight differences in metadata compared to the basic_metadata schema. The significant differences are creator is not a required form field, and description is a primary field. I believe by modifying the collection model used for most specs we can ensure the suggested inclusion of basic metadata into an application's collection model is well tested. Applications are still free to use a minimal collection based onPcdmCollection.Once basic metadata was included, the based_near/location field demanded fixes to function on collections as it does for works. Some feature specs needed additional actions to trigger the additional fields button, or to supply a creator value.
Changes proposed in this pull request:
:hyrax_collectionfactory. The Wings model registry is modified during specs to reflect this.:basic_metadataschema in koppie'sCollectionResource, bringing the model into closer alignment with what is in use in dassie.