Support all PCDM terms in Hyrax::FileMetadata::Use
#6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream Hyrax applications might use any of these, so for convenience Hyrax ought to provide them. Not included is `pcdmuse:PreservationMasterFile`, which is deprecated in favour of `pcdmuse:PreservationFile`. `Use::THUMBNAIL` has been aliased to `Use::THUMBNAIL_IMAGE`, which better matches the naming pattern of the other terms.
This will make it easier to deprecate `Use::THUMBNAIL` should we desire at a later date.
marrus-sh
force-pushed
the
pcdm_use_mas
branch
from
574e5a4
to
3087f3c
Compare
dlpierce
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Hyrax application makes use of
pcdmuse:PreservationFileandpcdmuse:IntermediateFile, and is currently overriding Hyrax to provide these constants. But the list of possible PCDM use terms is short and well known, and there’s no reason why Hyrax couldn’t just provide all of them to begin with.I’ve also taken the liberty of changing references to
Hyrax::FileMetadata::Use::THUMBNAILto beHyrax::FileMetadata::Use::THUMBNAIL_IMAGE, since that better matches the naming convention of the other terms.Hyrax::FileMetadata::Use::THUMBNAILis still supported, but probably should be discouraged.