Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue exception when collection is missing #6667

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Feb 2, 2024

Fixes

Fixes #6649

Summary

Rescues RecordNotFound error when collection is not found.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • A work with a missing collection does not raise an error in catalog controller search results.

Detailed Description

Rescuing this error makes this method behave the same as when the collection does not have a title field. In theory this situation is protected against by checks when deleting a collection, but in case "Life Finds a Way" this should prevent painful error screens.

@samvera/hyrax-code-reviewers

@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Feb 2, 2024
@jeremyf jeremyf merged commit fdcabe6 into main Feb 2, 2024
6 checks passed
@jeremyf jeremyf deleted the rescue_missing_collection branch February 2, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
2 participants