🧹 Add autoload for Forms #6685
Merged
🧹 Add autoload for Forms #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With moving the Hyrax::Forms class methods to hyrax/forms.rb we're seeing cases where the methods are not found. I suspect we need to declare the autoload for that module. Especially since these are our converter functions.
dlpierce
approved these changes
Feb 8, 2024
jeremyf
added a commit
that referenced
this pull request
Feb 8, 2024
* main: 🧹 Add autoload for Forms (#6685) 🐛 internal_resource and to_rdf_representation are assumptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With moving the Hyrax::Forms class methods to hyrax/forms.rb we're
seeing cases where the methods are not found.
I suspect we need to declare the autoload for that module. Especially
since these are our converter functions.