Add conditional to .fileset_for_directives
#6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are noticing that when ingesting a PDF, the `ValkyrieCreateDerivativesJob` is failing because the file_set doesn't get found in `ValkyriePersistDerivatives.fileset_for_directives` when the directives[:url] is an id instead of an actual uri, see `FileSetDerivativesService#extract_full_text`. I'm suggesting that we check if we have a "/" and if not we assume that it is an id so we can just look for that.
kirkkwang
force-pushed
the
ensure-extract-full-text-does-not-fail
branch
from
5890a71
to
b601b27
Compare
jeremyf
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Present tense short summary (50 characters or less)
We are noticing that when ingesting a PDF, the
ValkyrieCreateDerivativesJobis failing because the file_set doesn't get found inValkyriePersistDerivatives.fileset_for_directiveswhen the directives[:url] is an id instead of an actual uri, seeFileSetDerivativesService#extract_full_text. I'm suggesting that we check if we have a "/" and if not we assume that it is an id so we can just look for that.Guidance for testing, such as acceptance criteria or new user interface behaviors:
The testing was done on the
double_combobranch on Hyku but figured we'd need it inmainas well.Upload a PDF, observe that it the
ValkyrieCreateDerivativesJobfails.Type of change (for release notes)
Add an appropriate
notes-*label to the PR (or indicate here) that classifies this change.Choose from:
notes-bugfixBug FixesDetailed Description
Changes proposed in this pull request:
"/"if it isn't then we're assuming it's the UUID already.@samvera/hyrax-code-reviewers