🐛 Account for String and Valkyrie::ID Permissions #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**tl;dr** Given that we sometimes might compare `object.id` for permissions, we should treat Valkyrie::ID the same as the string. Woe is us, for checking permissions on a String, what once was an identifier, but which hath been usurped by the more rigid Valkyrie::ID. But loe, for the old ways still work. Granting permission to objects based on a string identifier. But Valkyrie::ID, one no longer a string, fails.
jeremyf
force-pushed
the
treat-valkyrie-id-and-string-same-for-permissions
branch
from
ddb84b9
to
2cde6c1
Compare
dlpierce
approved these changes
Feb 21, 2024
|
Yes, the |
dlpierce
deleted the
treat-valkyrie-id-and-string-same-for-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr Given that we sometimes might compare
object.idfor permissions, we should treat Valkyrie::ID the same as the string.Woe is us, for checking permissions on a String, what once was an identifier, but which hath been usurped by the more rigid Valkyrie::ID.
But loe, for the old ways still work. Granting permission to objects based on a string identifier. But Valkyrie::ID, one no longer a string, fails.
@samvera/hyrax-code-reviewers