Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to "Start another loop at end of route" #95

Closed
PhilipAmos opened this issue Jul 1, 2022 · 11 comments
Closed

Enhancement to "Start another loop at end of route" #95

PhilipAmos opened this issue Jul 1, 2022 · 11 comments
Labels
missing feature routebuilder Issues related to the Road Captain route builder runner Issues related to the Road Captain runner
Milestone

Comments

@PhilipAmos
Copy link

Is your feature request related to a problem? Please describe.
I like the idea of the "Start another loop at end of route" option but this only works if your route is a big loop.

What I would like to be able to do is do a lead in to a loop and then loop around that loop.

Describe the solution you'd like
Get the option to choose "Start another loop at end of route" for a route that has a lead in to a loop.

Describe alternatives you've considered
At the moment you have to keep plotting the loop which means you have to know in advance how many loops you will be performing.

Additional context
Here is an example of a loop with a lead in that I ike to ride.:

{
"version": "2",
"roadCaptainVersion": "0.6.4.0",
"route": {
"name": "RoadCaptain route starting on Big Loop",
"zwiftRouteName": "Big Loop",
"isLoop": false,
"routeSegmentSequence": [
{
"segmentId": "watopia-bambino-fondo-001-after-after-after-after-after-before",
"turnToNextSegment": "goStraight",
"nextSegmentId": "watopia-bambino-fondo-001-after-after-after-after-after-after",
"direction": "atoB"
},
{
"segmentId": "watopia-bambino-fondo-001-after-after-after-after-after-after",
"turnToNextSegment": "goStraight",
"nextSegmentId": "watopia-bambino-fondo-001-after-before",
"direction": "atoB"
},
{
"segmentId": "watopia-bambino-fondo-001-after-before",
"turnToNextSegment": "goStraight",
"nextSegmentId": "watopia-bambino-fondo-002-before-before-before",
"direction": "atoB"
},
{
"segmentId": "watopia-bambino-fondo-002-before-before-before",
"turnToNextSegment": "goStraight",
"nextSegmentId": "watopia-bambino-fondo-002-before-before-after",
"direction": "atoB"
},
{
"segmentId": "watopia-bambino-fondo-002-before-before-after",
"turnToNextSegment": "right",
"nextSegmentId": "watopia-climbers-gambit-001",
"direction": "atoB"
},
{
"segmentId": "watopia-climbers-gambit-001",
"turnToNextSegment": "none",
"nextSegmentId": null,
"direction": "atoB"
}
],
"world": "watopia",
"sport": "cycling"
}

@sandermvanvliet
Copy link
Owner

I like this 👍

@sandermvanvliet sandermvanvliet added runner Issues related to the Road Captain runner routebuilder Issues related to the Road Captain route builder labels Jul 1, 2022
@sandermvanvliet
Copy link
Owner

How about this:
In route builder when you click a segment again that you already have in your route, the app could ask “do you want to build a loop?”.
If you respond positive it can mark the segments from the start to that one as lead-in and the rest as the loop.

@PhilipAmos
Copy link
Author

Sounds good to me.

@sandermvanvliet sandermvanvliet changed the title Enhansement to "Start another loop at end of route" Enhancement to "Start another loop at end of route" Jul 4, 2022
@sandermvanvliet sandermvanvliet added this to the 0.6.6.0 milestone Jul 6, 2022
@sandermvanvliet
Copy link
Owner

@PhilipAmos the visuals aren't quite there yet but this is an example of a route that has a lead-in followed by a loop:
image

@sandermvanvliet
Copy link
Owner

Improved the UI in the side bar for this, what do you think?

image

@PhilipAmos
Copy link
Author

I think the second one looks good.

@sandermvanvliet
Copy link
Owner

Improved it a bit more:
image

@sandermvanvliet
Copy link
Owner

Lead in segments are shown with a dashed line on the map too:
image

@sandermvanvliet
Copy link
Owner

Need to do some in-game testing to see if the new route format works as expected, once that's done I'll cut a new release 👍

@sandermvanvliet
Copy link
Owner

It’s looking good. Going to test a few more things to make sure the loop count works as expected.

@sandermvanvliet
Copy link
Owner

All good, this will be in release 0.6.6.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature routebuilder Issues related to the Road Captain route builder runner Issues related to the Road Captain runner
Projects
None yet
Development

No branches or pull requests

2 participants