Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named colors with upper case letters are not recognized #134

Closed
VincentJousse opened this issue Nov 13, 2018 · 1 comment
Closed

Named colors with upper case letters are not recognized #134

VincentJousse opened this issue Nov 13, 2018 · 1 comment
Assignees
@palemieux
Labels
1.0 1.1 bug PR open
Milestone
1.0.2

Comments

@VincentJousse
Copy link

VincentJousse commented Nov 13, 2018 •
edited
Loading

According to https://www.w3.org/TR/ttml1/#style-value-namedColor :

For the purpose of parsing, a distinction must not be made between lower and upper case.

Yet, for exemple, Cyan is not detected.
@palemieux palemieux self-assigned this Nov 13, 2018
@palemieux palemieux modified the milestones: 1.0.2, 1.1 Nov 13, 2018
palemieux added a commit that referenced this issue Nov 13, 2018
@palemieux
Support arbitrary case Named Colors (#134)
0dc123f
@palemieux palemieux mentioned this issue Nov 13, 2018
Merged
palemieux added a commit that referenced this issue Nov 13, 2018
@palemieux
Support arbitrary case Named Colors (#134)
2fefcf1
@palemieux palemieux mentioned this issue Nov 13, 2018
Merged
@palemieux
Copy link
Contributor

@VincentFTS Thanks. See the two PRs for your review.

palemieux added a commit that referenced this issue Nov 16, 2018
@palemieux
Support case-insensitive Named Colors (#134)
07692da
palemieux added a commit that referenced this issue Nov 16, 2018
@palemieux
Support case-insensitive Named Colors (#134)
0d0b2b7
@palemieux palemieux modified the milestones: 1.1, 1.0.2 Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
1.0 1.1 bug PR open
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
2 participants
@palemieux @VincentJousse